Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call _kill when its not observable #15756

Closed
wants to merge 1 commit into from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Don't call _kill when its not observable. This skips a getter and call into JS until the PropertyCallback is called.

How did you verify your code works?

Existing tests

@Jarred-Sumner Jarred-Sumner requested a review from nektro December 14, 2024 02:49
@robobun
Copy link

robobun commented Dec 14, 2024

@Jarred-Sumner, your commit 76f4052 has 10 failures in #7963:

  • test/js/bun/http/serve.test.ts - 2 failing on 🍎 14 x64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 13 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - timeout on 🐧 20.04 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 12 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 24.04 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🍎 14 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🍎 13 x64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64
  • test/js/node/watch/fs.watchFile.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64-baseline
  • @Jarred-Sumner
    Copy link
    Collaborator Author

    This needs to apply on the setter and not just Object.defineProperty or the getter.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants