Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS moar fixes #15719

Merged
merged 11 commits into from
Dec 12, 2024
Merged

CSS moar fixes #15719

merged 11 commits into from
Dec 12, 2024

Conversation

zackradisic
Copy link
Contributor

What does this PR do?

  • Removes all occurrences of @panic(css.todo_stuff.depth) by either implementing the todo, or changing it with @compileError(css.todo_stuff.depth)
  • Fixes an issue with syntax property on @property rule which was preventing tailwind generated css code from working
  • Fixes an issue with printing calc(...) expressions which returned non-finite values
  • Add tests for gradients and fix a bunch of issues related to them

@robobun
Copy link

robobun commented Dec 12, 2024

@zackradisic, your commit a62d7c1 has 15 failures in #7845:

  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - timeout on 🐧 12 aarch64
  • test/v8/v8.test.ts - timeout on 🐧 20.04 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - timeout on 🐧 12 x64-baseline
  • test/js/third_party/mongodb/mongodb.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/cli/install/bun-run.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/cli/install/bun-run.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64
  • test/cli/install/bun-create.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 x64
  • test/js/node/watch/fs.watchFile.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64
  • @zackradisic zackradisic marked this pull request as ready for review December 12, 2024 01:51
    @Jarred-Sumner Jarred-Sumner merged commit fddc28d into main Dec 12, 2024
    61 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the zack/css-moar-fixes branch December 12, 2024 05:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants