Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readline test fixes #15688

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Readline test fixes #15688

wants to merge 18 commits into from

Conversation

heimskr
Copy link
Member

@heimskr heimskr commented Dec 10, 2024

What does this PR do?

Adds new readline tests from Node.js and changes to Bun that cause the tests to pass.

  • Documentation or TypeScript types
  • Code changes

How did you verify your code works?

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@robobun
Copy link

robobun commented Dec 10, 2024

@heimskr, your commit fe03672 has 23 failures in #7822:

  • test/js/bun/shell/leak.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/bun/shell/leak.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 24.04 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 12 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64
  • test/cli/install/bun-create.test.ts - timeout on 🐧 24.04 aarch64
  • test/cli/install/bun-create.test.ts - timeout on 🐧 12 x64
  • test/js/node/test/parallel/test-timers-immediate-queue.js - code 1 on 🐧 22.04 aarch64
  • test/js/node/test/parallel/test-timers-immediate-queue.js - code 1 on 🐧 24.04 x64
  • test/js/node/test/parallel/test-timers-immediate-queue.js - code 1 on 🐧 24.04 aarch64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 24.04 x64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 22.04 x64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 20.04 x64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 3.20 x64
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/regression/issue/11297/11297.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64-baseline
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2019 x64
  • test/js/third_party/prompts/prompts.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/stream/node-stream.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🪟 2019 x64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 12 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 24.04 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 24.04 x64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/stream/node-stream.test.js - 1 failing on 🐧 24.04 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🪟 2019 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 12 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 24.04 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/readline/readline.node.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • @190n 190n self-requested a review December 10, 2024 22:03
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants