Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More passing console tests #15676

Merged
merged 12 commits into from
Dec 12, 2024
Merged

More passing console tests #15676

merged 12 commits into from
Dec 12, 2024

Conversation

pfgithub
Copy link
Contributor

What does this PR do?

  • ✓ test-console-group
  • ✓ test-console-instance
  • ✓ test-console-no-swallow-stack-overflow
  • ✓ test-console-tty-colors
  • ✓ test-console-with-frozen-intrinsics
  • ✗ test-console-clear: overwrites process.stdout
  • ✗ test-console-count: overwrites process.stdout
  • ✗ test-console-formatTime: tests time printing which is from internal/util/debuglog
  • ✗ test-console-stdio-setters: overwrites process._stdout
  • ✗ test-console-table: bun centers fields, but node left-aligns fields
  • ✗ test-console: requires implementation of console._times & overwrites process.stdout with hijackstdio

@robobun
Copy link

robobun commented Dec 10, 2024

@pfgithub, your commit 3f9f08d has 12 failures in #7850:

  • test/js/node/test/parallel/test-http-no-content-length.js - code 1 on 🪟 2019 x64
  • test/js/bun/http/serve-body-leak.test.ts - 1 failing on 🪟 2019 x64
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 24.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/integration/next-pages/test/dev-server-ssr-100.test.ts - 1 failing on 🪟 2019 x64
  • @Jarred-Sumner
    Copy link
    Collaborator

    test-console-tty-colors is probably a CI env var conflict

    @Jarred-Sumner Jarred-Sumner merged commit 1b5cb89 into main Dec 12, 2024
    61 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the pfg/node-tests-1 branch December 12, 2024 09:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants