Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bundows] Skip unnecessary GetFinalPathNameByHandle #10338

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Skip unnecessary GetFinalPathNameByHandle

How did you verify your code works?

CI

Copy link
Contributor

@Electroid, there are failing tests:
There are 7 failing tests on bun-darwin-aarch64.

There are 6 failing tests on bun-darwin-x64-baseline.

There are 5 failing tests on bun-darwin-x64.

There are 5 failing tests on bun-linux-aarch64.

There are 2 failing tests on bun-linux-x64-baseline.

There are 3 failing tests on bun-linux-x64.

View logs

Copy link
Contributor

github-actions bot commented Apr 19, 2024

@Jarred-Sumner, your commit has failing tests :(

💻 1 failing tests Darwin x64

  • test/js/web/workers/worker.test.ts 1 failing

🪟💻 2 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 2 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 2 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

@Jarred-Sumner Jarred-Sumner merged commit ea1135a into main Jul 9, 2024
48 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/skip-GetFinalPathnameByHandle branch July 9, 2024 23:21
paperdave pushed a commit that referenced this pull request Jul 16, 2024
Co-authored-by: Ashcon Partovi <[email protected]>
Co-authored-by: Jarred-Sumner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants