Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node:*: fix some typescript errors #10310

Merged
merged 18 commits into from
Apr 23, 2024
Merged

node:*: fix some typescript errors #10310

merged 18 commits into from
Apr 23, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Apr 17, 2024

notable fixes

  • missing validators
  • missing primordials
  • primordials defined wrong
  • missing identifiers
  • missing builtins
  • missing type definitions
  • duplicate definitions clobbering names
  • ArrayIsArray being called wrong
  • passing arguments to functions that don't use them
  • misc parameter and array type safety
  • error builtins being called wrong

Copy link
Contributor

github-actions bot commented Apr 19, 2024

@nektro, your commit has failing tests :(

💪 3 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 2 failing tests Darwin x64

🐧💪 5 failing tests Linux AARCH64

🐧🖥 3 failing tests Linux x64 baseline

🐧🖥 4 failing tests Linux x64

🪟💻 14 failing tests Windows x64 baseline

🪟💻 13 failing tests Windows x64

View logs

@oven-sh oven-sh deleted a comment from github-actions bot Apr 22, 2024
@oven-sh oven-sh deleted a comment from github-actions bot Apr 22, 2024
@oven-sh oven-sh deleted a comment from github-actions bot Apr 22, 2024
@oven-sh oven-sh deleted a comment from github-actions bot Apr 22, 2024
@oven-sh oven-sh deleted a comment from github-actions bot Apr 22, 2024
@Jarred-Sumner Jarred-Sumner merged commit 0f8d74e into main Apr 23, 2024
44 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the nektro-patch-55397 branch April 23, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants