-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(posix): ensure nonblocking file descriptor is nonblocking (#10080) #10303
Open
alexkornitzer
wants to merge
2
commits into
oven-sh:main
Choose a base branch
from
alexkornitzer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { test, expect } from "bun:test"; | ||
import { bunEnv, bunExe, isPosix } from "harness"; | ||
import { tmpdir } from "os"; | ||
import { join } from "path"; | ||
|
||
test.if(isPosix)( | ||
"10080 - ensure blocking stdio is treated as such in FileReader", | ||
async () => { | ||
const expected = "foobar\n"; | ||
const filename = join(tmpdir(), "bun.test.stream." + Date.now() + ".js"); | ||
const contents = "for await (const line of console) {console.log(`foo${line}`)}"; | ||
await Bun.write(filename, contents); | ||
const shellCommand = `exec &> >(${bunExe()} ${filename}); echo "bar"; while read -r line; do echo $line; done`; | ||
|
||
const proc = Bun.spawn(["bash", "-c", shellCommand], { | ||
stdin: "inherit", | ||
stdout: "pipe", | ||
stderr: "inherit", | ||
env: bunEnv, | ||
}); | ||
const { value } = await proc.stdout.getReader().read(); | ||
const output = new TextDecoder().decode(value); | ||
if (output !== expected) { | ||
expect(output).toEqual(expected); | ||
throw new Error("Output didn't match!\n"); | ||
} | ||
|
||
proc.kill(9); | ||
await proc.exited; | ||
expect(proc.killed).toBeTrue(); | ||
}, | ||
1000, | ||
); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this, do you need any action from me? Would you like me to rebase against master and apply the above suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that would be great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I tried to align the formatting to that of other
@compileError
functions within the file. I also squashed the formatting commit into the original commit to keep the git history clean.