Testing workflows #10157
Merged
Testing workflows #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electroid
force-pushed
the
fast-ci
branch
3 times, most recently
from
4bcda1f to
a4b9b50
Compare
paperdave
requested changes
Apr 15, 2024
| @@ -409,6 +409,7 @@ for (const path of allTests) { | |||
| process.exit(1); | |||
| }), | |||
| ); | |||
| break; // HACK | |||
There was a problem hiding this comment.
this isnt intentional for final i assume
.github/workflows/build-windows.yml
Outdated
| type: boolean | ||
| default: false | ||
| deoptimize: | ||
| type: boolean |
There was a problem hiding this comment.
is there a reason this cannot be named optimize and be a string? with the default being ReleaseFast?
paperdave
approved these changes
Apr 17, 2024
| env: | ||
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1 | ||
| HOMEBREW_NO_AUTO_UPDATE: 1 | ||
| HOMEBREW_NO_INSTALL_CLEANUP: 1 |
There was a problem hiding this comment.
we should add that 4th arg
| generate_release_notes: false | ||
| files: bun/* | ||
| - name: Upload to S3 (using SHA) | ||
| uses: shallwefootball/s3-upload-action@4350529f410221787ccf424e50133cbc1b52704e |
There was a problem hiding this comment.
I don't love relying on this random github action that hasn't been updated in a year https://github.com/shallwefootball/upload-s3-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not merge. Work in progress.
How did you verify your code works?