dont create JSString for ASCIILiteral

oven-sh · Dec 14, 2024 · 8b17029 · 8b17029
1 parent 9201b88
commit 8b17029
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/bun.js/bindings/NodeValidator.cpp b/src/bun.js/bindings/NodeValidator.cpp
@@ -518,11 +518,10 @@ JSC_DEFINE_HOST_FUNCTION(jsFunction_validateBuffer, (JSC::JSGlobalObject * globa
     auto name = callFrame->argument(1);
     return V::validateBuffer(scope, globalObject, buffer, name);
 }
-JSC::EncodedJSValue V::validateBuffer(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSValue buffer, JSValue name)
+JSC::EncodedJSValue V::validateBuffer(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSValue buffer, JSValue nameValue)
 {
-    JSC::VM& vm = globalObject->vm();
-
-    if (name.isUndefined()) name = jsString(vm, String("buffer"_s));
+    auto name = nameValue.isUndefined() ? "buffer"_s : nameValue.toWTFString(globalObject);
+    RETURN_IF_EXCEPTION(scope, {});
 
     if (!buffer.isCell()) return JSValue::encode(jsUndefined());
     auto ty = buffer.asCell()->type();