Add variable for ephemeral_storage in metadata-service aws_ecs_task_definition #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM once linter passes. Best way is to install terraform-docs-go and/or pre-commit and let it format the readme |
|
👍 This change would help my team work around a limitation we are running into -- any update on getting it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[issue #85]
The ephemeral_storage is currently not defined in the metadata-service submodule so it is set to its default value of 21Gb.
I've added a variable called
metadata_service_ephemeral_storagewhich would allow users to define the metadata task disk space in the root module