Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export more params and format #112

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

avevotsira
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
libsql-studio ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:47am
libsql-studio-preview ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 2:47am

Copy link

github-actions bot commented Jul 17, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.95% (-3.33% 🔻)
736/969
🟡 Branches
60.39% (-0.48% 🔻)
186/308
🟡 Functions
69.49% (-5.51% 🔻)
123/177
🟡 Lines
77.42% (-3.61% 🔻)
689/890
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / export-helper.ts
47% 44.44% 45.45% 44.94%

Test suite run success

62 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 893e8aa

@avevotsira avevotsira linked an issue Jul 17, 2024 that may be closed by this pull request
@avevotsira avevotsira marked this pull request as ready for review July 17, 2024 14:55
@avevotsira avevotsira requested review from invisal and rin-yato and removed request for invisal July 17, 2024 15:22
@avevotsira
Copy link
Contributor Author

also , the call back needed my readonly const inside dependency array? :/

@avevotsira avevotsira requested a review from invisal July 24, 2024 02:39
@avevotsira
Copy link
Contributor Author

I kinda wanna do unit test for this lol? any template ?

@invisal
Copy link
Collaborator

invisal commented Jul 24, 2024

@avevotsira you can follow the template of other test. Maybe we can discuss more during our party meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown, Ascii Table and more export parameters
2 participants