Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-350[NOETIC]: 't' timestamp field content is not plausible #386

Merged
merged 4 commits into from
Oct 11, 2024
Merged

ROS-350[NOETIC]: 't' timestamp field content is not plausible #386

merged 4 commits into from
Oct 11, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Oct 9, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Don't apply offset to destaggered timestamps within the point cloud
  • Make sure the the timestamps align correctly when destaggerd is option is OFF
  • Misc: update bug/question templates

Validation

  • run the driver with default option (destaggered=ON, organized=ON)
    • observe that the timestamps are consistent
  • run the driver with default option (destaggered=OFF, organized=ON)
    • observe that the timestamps appear staggerd

@Samahu Samahu added the bug Something isn't working label Oct 9, 2024
@Samahu Samahu self-assigned this Oct 9, 2024
@Samahu Samahu changed the title ROS-350: 't' timestamp field content is not plausible ROS-350[NOETIC]: 't' timestamp field content is not plausible Oct 9, 2024
@Samahu Samahu marked this pull request as ready for review October 10, 2024 21:09
@Samahu Samahu merged commit 92ab33d into master Oct 11, 2024
1 check passed
@Samahu Samahu deleted the ROS-350_t_timestamp_field_content_is_not_plausible branch October 11, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@Krishtof-Korda Krishtof-Korda Awaiting requested review from Krishtof-Korda

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

@diego-guridi diego-guridi Awaiting requested review from diego-guridi

Assignees

@Samahu Samahu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

't' timestamp field content is not plausible
2 participants
@Samahu @matthew-lidar