Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUMBLE|IRON|JAZZY] Port ROS-363 to ROS2 #369

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Sep 16, 2024

Related Issues & PRs

Summary of Changes

  • Update to SDK client 0.11.1
  • Switch to using LidarPacket and ImuPacket
    • Get's rid of the deprecation warnings
  • Publish raw packets for the os_driver
  • Add a flag to control the publish of organized point cloud vs non-organized
  • Add a flag to control the publish of destaggerd point cloud vs staggered
  • Add parameter to set the min/max lidar range on generated point clouds
  • Add a new flag to proc_mask to optionally publish the raw packets when using os_driver

TODO(s)

  • publicize the use of OpenMP in cartesianT & point_cloud_compose methods

Validation

  • Run the driver in all different modes of operations
  • Verify that the newly added features:
    • When destagger is set to false verify the driver doesn't destagger the published point cloud
    • When organized is set to false verify that the published point cloud isn't 2D
    • Adjust min_range and max_range and observe the point cloud shrink accordingly.
  • Verify that /ouster/imu_packets and /ouster/lidar_packet appear when RAW flag is passed to os_driver

@Samahu Samahu added the enhancement New feature or request label Sep 16, 2024
@Samahu Samahu self-assigned this Sep 16, 2024
@Samahu Samahu changed the title Port ROS-363 to ROS2 [HUMBLE|IRON|JAZZY] Port ROS-363 to ROS2 Sep 17, 2024
@@ -46,6 +46,7 @@ set(BUILD_SHARED_LIBS OFF)

option(BUILD_VIZ "Turn off building VIZ" OFF)
option(BUILD_PCAP "Turn off building PCAP" OFF)
option(BUILD_OSF "Turn off building OSF" OFF)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope, but the language on these comments is confusing. The wording implies that when set to OFF it builds these options.

@Samahu Samahu marked this pull request as ready for review September 20, 2024 20:51
@Samahu Samahu merged commit 5dd8555 into ros2 Sep 20, 2024
4 checks passed
@Samahu Samahu deleted the further-reduce-overhead-in-the-ros-driver-ros2 branch September 20, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants