Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-227: Set LIDAR FOV on startup and add an option to persist the config [NOETIC] #356

Merged
merged 9 commits into from
Aug 20, 2024
Merged

ROS-227: Set LIDAR FOV on startup and add an option to persist the config [NOETIC] #356

merged 9 commits into from
Aug 20, 2024
+88 −6

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Aug 19, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Set LIDAR FOV on startup
  • Add an option to persist the config

Validation

  • Run the node with azimuth start and stop as follows
roslaunch ouster_ros driver.launch \
    azimuth_window_start:=150000 \
    azimuth_window_end:=250000

Verify that the azimuth window is cropped to selection

  • Run the node with persist_config set true as follows
roslaunch ouster_ros driver.launch \
   <pass a selection of settings> \
    persist_config:=true

Verify that the new settings persist after power up/down cycle of the sensor

@Samahu Samahu added the enhancement New feature or request label Aug 19, 2024
@Samahu Samahu self-assigned this Aug 19, 2024
@Samahu Samahu changed the title Ros 227 changing lidar fov noetic ROS-227 changing lidar fov noetic Aug 19, 2024
@Samahu Samahu changed the title ROS-227 changing lidar fov noetic ROS-227: Set LIDAR FOV on startup [NOETIC] Aug 19, 2024
Samahu
Samahu commented Aug 19, 2024
View reviewed changes
src/os_sensor_nodelet.cpp Outdated Show resolved Hide resolved
Samahu
Samahu commented Aug 19, 2024
View reviewed changes
launch/driver.launch Outdated Show resolved Hide resolved
@Samahu Samahu changed the title ROS-227: Set LIDAR FOV on startup [NOETIC] ROS-227: Set LIDAR FOV on startup and add an option to persist the config [NOETIC] Aug 19, 2024
@Samahu Samahu marked this pull request as ready for review August 19, 2024 18:16
matthew-lidar
matthew-lidar approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@matthew-lidar matthew-lidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just maybe consider changing the language of the warning.

twslankard
twslankard approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@twslankard twslankard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@Samahu Samahu merged commit 8b81347 into master Aug 20, 2024
1 check passed
@Samahu Samahu deleted the ROS-227-changing-lidar-fov-noetic branch August 20, 2024 19:49
This was referenced Aug 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar approved these changes

@Krishtof-Korda Krishtof-Korda Krishtof-Korda approved these changes

@twslankard twslankard twslankard approved these changes

@celentes celentes Awaiting requested review from celentes

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting sensor config
4 participants
@Samahu @twslankard @Krishtof-Korda @matthew-lidar