AO3-931 Show placeholder for deleted invitee #5000
Conversation
config/locales/views/en.yml
Outdated
| copy_and_use: copy and use | ||
| copy_link: Copy link | ||
| created_at: Created at | ||
| deleted_user: deleted user (%{user_id}) |
There was a problem hiding this comment.
Can you capitalize "Deleted" here so the invitee and sender will match when we do AO3-6095? I was going to say I'd add the user ID to that issue, but I think it would show the ID to users, not just admins, so we probably don't want that.
Relatedly, are we sure this only shows the user ID if you're an admin?
There was a problem hiding this comment.
Oh at the moment it definitely shows to both, my thought was it's not a big concern because user ID isn't PII. But it's also not particularly useful to a non-admin so I am also not opposed to adding another check in the helper
There was a problem hiding this comment.
Let's go with an additional check, then! I'll update AO3-6095 to request the same behavior.
github-actions
bot
added
Coder Has Actioned Review
and removed
Reviewed: Action Needed
labels
| link_to(invitation.creator.login, invitation.creator) | ||
| elsif invitation.creator.is_a?(Admin) | ||
| when Admin |
There was a problem hiding this comment.
I might be wandering out of scope here, but while I was updating AO3-6095, I noticed it specifies using Deleted admin when the admin is deleted. We don't cover that case here, so is it possible this page would either 500 or incorrectly specify the queue if the admin who issued an invitation was now deleted?
| deleted_user: deleted user | ||
| deleted_user_with_id: deleted user (%{user_id}) |
There was a problem hiding this comment.
Could you fix the capitalization here? shakes fist at lowercase
|
Oh, hey, this is actually the updated version of the issue you worked on: https://otwarchive.atlassian.net/issues/AO3-5498 Would you like to grab that and finish it off? |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-931 (yes, that's a real ticket number 😅 )
Purpose
When a user sends an invitation, someone accepts it, and then the invitee deletes their account, show the old invitee as a placeholder (suggested by PAC/Support elsewhere):
Side note: the invitation detail page is... a bit confusing as-is. I'm OK using this story to update that if we want, but I haven't done that on my own for a number of reasons.