update sjj to work with latest sdp examples #28
Conversation
jensengar
force-pushed
the
accommodate-sdp-changes
branch
from
a8af734 to
8e4913a
Compare
| applicationType: 'datachannel', | ||
| port: mline.port, | ||
| sctpPort: sctpPort, | ||
| maxMessageSize: maxMessageSize |
There was a problem hiding this comment.
this is transported via xep-0343 which would need to be updated along with the stanza definitions?
There was a problem hiding this comment.
I'm a bit unclear about what you mean by this. Is there something I need to do here?
There was a problem hiding this comment.
the xmpp way to transport this is currently from here
<sctpmap xmlns='urn:xmpp:jingle:transports:dtls-sctp:1' number='5000' protocol='webrtc-datachannel' streams='1024'/>
which doesn't transport things like maxMessageSize. So I expect that if you signal this you'll need to update the stanza.io version you're using as well.
| @@ -194,6 +204,10 @@ exports.toMediaJSON = function (media, session, opts) { | |||
| trans.fingerprints.push(fp); | |||
| }); | |||
|
|
|||
| if (parsers.findLine('a=ice-options:trickle', lines)) { | |||
There was a problem hiding this comment.
i'd do this in a separate PR/commit for atomicity
There was a problem hiding this comment.
actually this shouldn't be mapped. First its not really relevant in the SDP, second, as xep-0371 explains we have disco for this kind of stuff.
I changed the sdp to be actual sdp from chrome.