Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spf13 role #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added spf13 role #6

wants to merge 1 commit into from

Conversation

keithhamilton
Copy link

Liked the maximum-awesome role, but I prefer spf13. Added a simple role that adds most of the stuff that your maximum-awesome role does (iterm, macvim, tmux), but then puts spf13 on top of it and runs the bootstrap script to fully install it.

Tested on: Mac OS X 10.9.2

@program247365
Copy link

👍 Agree on the spf13.

@keithhamilton
Copy link
Author

woot!

#############################

Keith Hamilton

Engineer, Wieden+Kennedy

mobile: 503.928.0913

desk: 503.937.7476

#############################

On May 5, 2014, at 8:33 PM, Kevin Ridgway <[email protected]mailto:[email protected]> wrote:

[:+1:] Agree on the spf13.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-42265275.

@rricard
Copy link
Contributor

rricard commented May 6, 2014

Seems like a good idea !

There are two objections for me:

  1. You should do this PR in xc-common, because it's shared by everyone and you'll be able to deploy it more easily.
  2. I'm not keen on installation scripts. If possible, can you use the git_package role as a dependency and relink it with ansible ? (just as I did in maximum-awesome)

@keithhamilton
Copy link
Author

Hey Robin,
Responses to your objections:

  1. Yeah I wasn't sure if I was to branch xc-common or not, but can do.
  2. As for using rake or similar to relink, I'm not sure the release branch of spf13 is set up to do this. the bootstrap.sh script that is part of the repo (so you can avoid a curl spoof), is basically a rake file written in bash, doing all of the bundle and dependency management for the vim setup. Without forking spf13 and rewriting the install method, and getting it accepted into the master branch, I'm not sure I'd be able to do exactly what you're doing with maximum-awesome.

Let me know where you stand on point two. If you are ok with moving ahead with using the spf13 bootstrap script, I'll submit this as a pull request to xc-common.

Thanks!
Keith


Brought to you by Carl's Jr.

On May 6, 2014, at 1:49 AM, "Robin Ricard" <[email protected]mailto:[email protected]> wrote:

Seems like a good idea !

There are two objections for me:

  1. You should do this PR in xc-common, because it's shared by everyone and you'll be able to deploy it more easily.
  2. I'm not keen on installation scripts. If possible, can you use the git_package role as a dependency and relink it with ansible ? (just as I did in maximum-awesome)


Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-42279466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants