rust: Switch to using include
#3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
rust-switch-include
branch
from
3c97bc5 to
0e370a3
Compare
This way we don't randomly pick up bits from the C library unintentionally as things change on that side. I think the support for `!` in `include` may be relatively new and that's why the original author here chose to do things via `exclude`. But using `include` with a few specific exclusions is just way better.
cgwalters
force-pushed
the
rust-switch-include
branch
from
0e370a3 to
26dcd4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't randomly pick up bits from the C library unintentionally as things change on that side.
I think the support for
!inincludemay be relatively new and that's why the original author here chose to do things viaexclude. But usingincludewith a few specific exclusions is just way better.