-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Fix composefs test #2923
Conversation
I have no idea why this test failed here. It works locally, and it worked in #2922 |
Hmm I'm getting a different digest...(time passes) Ah of course...I think it's the selinux xattrs. I have them on this Fedora host, but Debian doesn't. Oh wait...or maybe it's the other way around? Huh...I think the test suite is actually disabling xattrs in my toolbox container but that may not be happenining in the debian setup? Testing... |
bd9b011
to
176d2be
Compare
The default GVariant output for byte arrays is illegible to humans, and byte arrays are super common for us.
176d2be
to
4baf3a4
Compare
I tried the latest version of this branch locally on f38 and I get the same digest as the debian latest CI does ( @cgwalters Do you get |
I'm running in a f38 toolbox container. Hmm can you give this a quick try?
I get:
|
Uhm, I get:
|
|
So, either have two possible digests, or use a different commit to compare against? |
- Was using the wrong metadata key - We were missing setting the canonical commit args which assigns e.g. owner uid 0, which is important for reproducibility - Use the new --print-hex to make things easier to read
4baf3a4
to
62e4f37
Compare
Ahhhh! Right, obvious in retrospect just looking at the code. (Hmm, we need a saner and more representative set of "canonical filesystem trees to test") I took a crack at a fix. |
This was using the wrong metadata key and had an old digest.
Split out from #2922