-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker/* targets in Makefile #1028
Conversation
@maxfisher-g please review |
Hi @gliptak, thanks for your continued work on this issue! Looking at the linked issue and example Makefile, I think the 'top level' recipes should be verbs like Additionally, can we make it so that
Thanks very much! |
updated. please let me know |
@gliptak nice, thank you! One more thing, if you look at the original comment in #647, the format of the recipes is like Currently, the recipes in our Makefile look like e.g. This would be much appreciated :) |
Signed-off-by: Gábor Lipták <[email protected]>
@maxfisher-g thank you. updated |
Thanks for the update @gliptak! Could you please add an entry for The group targets e.g. |
Signed-off-by: Gábor Lipták <[email protected]>
@maxfisher-g updated sync |
@gliptak thank you! I'll merge ;) |
Fixes #647