Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): Use the default image root when running Docker #9624

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sschuberth
Copy link
Member

Use the same image root that docker_build.sh uses by default.

Use the same image root that `docker_build.sh` uses by default.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner December 16, 2024 22:50
@sschuberth sschuberth enabled auto-merge (rebase) December 16, 2024 22:50
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (81f58ea) to head (a0f2a8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9624   +/-   ##
=========================================
  Coverage     68.05%   68.05%           
  Complexity     1285     1285           
=========================================
  Files           249      249           
  Lines          8835     8835           
  Branches        921      921           
=========================================
  Hits           6013     6013           
  Misses         2433     2433           
  Partials        389      389           
Flag Coverage Δ
funTest-docker 65.14% <ø> (ø)
funTest-non-docker 33.31% <ø> (ø)
test-ubuntu-24.04 35.84% <ø> (ø)
test-windows-2022 35.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit 806363a into main Dec 17, 2024
26 checks passed
@sschuberth sschuberth deleted the docker-run-fix branch December 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants