Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(opossum): Prefer add functions when building collections #9617

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

sschuberth
Copy link
Member

Avoid any confusion what this refers to for these (extension) functions.

Avoid any confusion what `this` refers to for these (extension) functions.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner December 16, 2024 11:14
@sschuberth sschuberth enabled auto-merge (rebase) December 16, 2024 11:14
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (6db8eae) to head (63db06b).

Files with missing lines Patch % Lines
...rc/main/kotlin/utils/SortedCollectionConverters.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9617   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     1285     1285           
=========================================
  Files           249      249           
  Lines          8828     8828           
  Branches        921      921           
=========================================
  Hits           6005     6005           
  Misses         2433     2433           
  Partials        390      390           
Flag Coverage Δ
funTest-docker 64.96% <ø> (ø)
test-ubuntu-24.04 35.80% <0.00%> (ø)
test-windows-2022 35.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth disabled auto-merge December 16, 2024 11:38
@sschuberth
Copy link
Member Author

Merging despite the unrelated DownloaderFunTest failure.

@sschuberth sschuberth merged commit 03d9166 into main Dec 16, 2024
24 of 26 checks passed
@sschuberth sschuberth deleted the opossum-chore branch December 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants