NPM: Collect issues when listing packages instead of failing #9616
+835
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MarcelBochtler
force-pushed
the
npm-list-issues
branch
from
3603b45 to
eefb222
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9616 +/- ##
============================================
+ Coverage 68.03% 68.06% +0.02%
Complexity 1287 1287
============================================
Files 249 249
Lines 8826 8836 +10
Branches 920 921 +1
============================================
+ Hits 6005 6014 +9
- Misses 2432 2433 +1
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarcelBochtler
force-pushed
the
npm-list-issues
branch
9 times, most recently
from
18d448b to
6d76a0f
Compare
sschuberth
requested changes
Dec 16, 2024
...ins/package-managers/node/src/funTest/assets/projects/synthetic/npm/list-issues/package.json
Show resolved
Hide resolved
plugins/package-managers/node/src/funTest/kotlin/npm/NpmFunTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Marcel Bochtler <[email protected]>
These messages are printed on `stderr`, listing one dependency per line. Signed-off-by: Marcel Bochtler <[email protected]>
In an upcoming commit, `stderr` will be passed to the `groupLines()` function. The log file message should not be added as an `Issue`, therefore add it as an ignorable prefix. Signed-off-by: Marcel Bochtler <[email protected]>
If `npm list` returns with a non-zero exit code, do not throw an exception and consequently stop the analysis. Instead, collect the errors from `stderr` as `Issue`s and continue analyzing the project, because useful dependency information may still be available. Resolves oss-review-toolkit#9551. Signed-off-by: Marcel Bochtler <[email protected]>
MarcelBochtler
force-pushed
the
npm-list-issues
branch
from
6d76a0f to
83223f5
Compare
sschuberth
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect errors from the
npm listcommand printed on stderr like: