Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align on constructing URIs without create() #9610

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

sschuberth
Copy link
Member

For the difference see 1.

@sschuberth sschuberth requested a review from a team as a code owner December 13, 2024 21:21
@sschuberth sschuberth enabled auto-merge (rebase) December 13, 2024 21:21
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (4872713) to head (8ab1ba1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/commands/classifications/ImportCommand.kt 0.00% 3 Missing ⚠️
utils/ort/src/main/kotlin/storage/S3FileStorage.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9610   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     1287     1287           
=========================================
  Files           249      249           
  Lines          8828     8828           
  Branches        921      921           
=========================================
  Hits           6005     6005           
  Misses         2433     2433           
  Partials        390      390           
Flag Coverage Δ
funTest-docker 64.96% <ø> (ø)
funTest-non-docker 33.45% <0.00%> (-0.06%) ⬇️
test-ubuntu-24.04 35.80% <0.00%> (ø)
test-windows-2022 35.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth sschuberth merged commit fce2829 into main Dec 13, 2024
25 of 26 checks passed
@sschuberth sschuberth deleted the uri-no-create branch December 13, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants