Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test EnvironmentVariableFilter with an empty deny list #9605

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Test EnvironmentVariableFilter with an empty deny list #9605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b06f9
chore(common-utils): Uniformly use lists in `EnvironmentVariableFilte…
sschuberth Dec 13, 2024
7192bfa
test(common-utils): Test `EnvironmentVariableFilter` with empty deny …
sschuberth Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion utils/common/src/test/kotlin/EnvironmentVariableFilterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class EnvironmentVariableFilterTest : StringSpec({
"Allowed names can be changed" {
val allowedSecret = "MAVEN_REPO_PASSWORD"

EnvironmentVariableFilter.reset(allowNames = setOf(allowedSecret))
EnvironmentVariableFilter.reset(allowNames = listOf(allowedSecret))

EnvironmentVariableFilter.isAllowed(allowedSecret) shouldBe true
}
Expand All @@ -80,4 +80,18 @@ class EnvironmentVariableFilterTest : StringSpec({

environment should containExactly(filteredEnvironment)
}

"An empty deny list should not deny anything" {
EnvironmentVariableFilter.reset(denySubstrings = emptyList())

EnvironmentVariableFilter.DEFAULT_DENY_SUBSTRINGS.forAll {
EnvironmentVariableFilter.isAllowed(it) shouldBe true
}

EnvironmentVariableFilter.DEFAULT_ALLOW_NAMES.forAll {
EnvironmentVariableFilter.isAllowed(it) shouldBe true
}

EnvironmentVariableFilter.isAllowed("PATH") shouldBe true
fviernau marked this conversation as resolved.
Show resolved Hide resolved
}
})
Loading