fix(compose): Ignore definition files from vendor directories #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8981 +/- ##
============================================
+ Coverage 67.97% 68.02% +0.05%
Complexity 1158 1158
============================================
Files 241 241
Lines 7690 7690
Branches 867 867
============================================
+ Hits 5227 5231 +4
+ Misses 2106 2103 -3
+ Partials 357 356 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mnonnenmacher
requested changes
Aug 14, 2024
In addition to 471a65d, also ignore any `composer.json` files from `vendor` directories before resolving dependencies. This avoids packages for dependencies being recognized as projects by the ORT analyzer. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
composer-no-vendor-projects
branch
from
8cace5b to
ccd03df
Compare
mnonnenmacher
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to 471a65d, also ignore any
composer.jsonfiles fromvendordirectories before resolving dependencies. This avoids packages for dependencies being recognized as projects by the ORT analyzer.