Add a reporter for the AOSD 2 format #8980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the docs slightly while at it. Signed-off-by: Sebastian Schuberth <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/reporters/aosd/src/main/kotlin/AudiOpenSourceDiagnosticsReporter.kt
Fixed
Show fixed
Hide fixed
sschuberth
force-pushed
the
aosd-reporter
branch
from
433f8ac to
4d72d0d
Compare
sschuberth
force-pushed
the
aosd-reporter
branch
from
4d72d0d to
64e7424
Compare
The `License`'s `spdx` field should not contain any license name, but only a real SPDX ID, if any. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
aosd-reporter
branch
from
64e7424 to
cb82e6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8980 +/- ##
=========================================
Coverage 67.97% 67.97%
Complexity 1158 1158
=========================================
Files 241 241
Lines 7690 7690
Branches 867 867
=========================================
Hits 5227 5227
Misses 2106 2106
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
aosd-reporter
branch
from
cb82e6c to
b4eca61
Compare
mnonnenmacher
requested changes
Aug 13, 2024
plugins/reporters/aosd/src/main/kotlin/AudiOpenSourceDiagnosticsReporter.kt
Outdated
Show resolved
Hide resolved
| LicenseView.ONLY_DETECTED, | ||
| AOSD2.Origin.SCM, | ||
| copyrights | ||
| ) |
There was a problem hiding this comment.
Don't we format multi-line when cases always with curly braces?
There was a problem hiding this comment.
I guess we usually do... it was formatted that way by IntelliJ, and since Detekt did not complain, I left it that way to avoid some additional nesting / lines. Do you prefer to have curly braces?
There was a problem hiding this comment.
No, actually I would prefer to omit curly braces in such cases.
AOSD 2 stands for Audi Open Source Diagnostics, version 2. See [1]. [1]: https://www.aosd.cloud.audi/help Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
aosd-reporter
branch
from
b4eca61 to
50563bf
Compare
mnonnenmacher
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.