Migrate to the new SCANOSS client #8978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8978 +/- ##
============================================
+ Coverage 67.64% 67.97% +0.32%
+ Complexity 1168 1158 -10
============================================
Files 244 241 -3
Lines 7783 7690 -93
Branches 867 867
============================================
- Hits 5265 5227 -38
+ Misses 2161 2106 -55
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is a preparation for migrating from the currently used library [1], which is deprecated, to the newer library [2] which does not offer `BlacklistRules` anymore. The newer library instead skips certain file extensions itself as part of the winnowing algorithm, see [3]. [1]: https://github.com/scanoss/scanner.java [2]: https://github.com/scanoss/scanoss.java [3]: https://github.com/scanoss/scanoss.java/blob/8598c47/src/main/java/com/scanoss/Winnowing.java#L204-L210 Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
new-scanoss-client
branch
from
a5e16c9 to
4199ffe
Compare
sschuberth
force-pushed
the
new-scanoss-client
branch
from
4199ffe to
7e22235
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sschuberth
force-pushed
the
new-scanoss-client
branch
from
7e22235 to
7dd6fee
Compare
mnonnenmacher
requested changes
Aug 10, 2024
Migrate from [1] to [2]. Resolves #6672. [1]: https://github.com/scanoss/scanner.java [2]: https://github.com/scanoss/scanoss.java Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
new-scanoss-client
branch
from
7dd6fee to
a2c6663
Compare
This helps to detect changes in the algorithm, e.g. on library updates. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
new-scanoss-client
branch
from
a2c6663 to
bcb49cc
Compare
mnonnenmacher
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.