Various Composer improvements #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To not confuse the analyzer with a "dirty" working directory, stash away any present "vendor" directory [1] when running `composer`, similar as done for `GoMod`. [1]: https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies Signed-off-by: Sebastian Schuberth <[email protected]>
This small function is only used once and does not actually "parse" anything anymore itself. Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8975 +/- ##
=========================================
Coverage 67.64% 67.64%
Complexity 1168 1168
=========================================
Files 244 244
Lines 7783 7783
Branches 867 867
=========================================
Hits 5265 5265
Misses 2161 2161
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Align on not using `with =` as it is the only parameter for the annotation anyway. Signed-off-by: Sebastian Schuberth <[email protected]>
The function's docs say: "This overload works with full type information, including type arguments and nullability, and is a recommended way to retrieve a serializer." Signed-off-by: Sebastian Schuberth <[email protected]>
Note that KxS requires to explicitly state default values even for nullable types, while Jackson implicitly defaults to null for nullable types. Signed-off-by: Sebastian Schuberth <[email protected]>
Quoting [1]: "The license of the package. This can be either a string or an array of strings." [1]: https://getcomposer.org/doc/04-schema.md#license Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
changed the title
mnonnenmacher
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.