refactor(conan): Simplify the parsing of ConanData #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val hasPatches = patchesForVersion?.items.orEmpty().isNotEmpty() | ||
| val url = sourceForVersion?.get<YamlNode>("url")?.let { | ||
| when { | ||
| it is YamlList -> it.yamlList?.items?.first()?.yamlScalar?.content |
Check warning
Code scanning / detekt
Unnecessary safe call operator detected. Warning
sschuberth
reviewed
Jul 18, 2024
| @@ -450,3 +422,28 @@ class Conan( | |||
| private fun parseAuthors(pkgInfo: PackageInfo): Set<String> = | |||
| setOfNotNull(parseAuthorString(pkgInfo.author.orEmpty(), '<', '(')) | |||
| } | |||
|
|
|||
| private data class Conandata( | |||
There was a problem hiding this comment.
Maybe call this "ConanData" for readability and to match "readConanData"?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8907 +/- ##
=========================================
Coverage 67.63% 67.63%
Complexity 1168 1168
=========================================
Files 244 244
Lines 7781 7781
Branches 867 867
=========================================
Hits 5263 5263
Misses 2161 2161
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
simplify-conandata-parsing
branch
from
5110717 to
078c153
Compare
fviernau
changed the title
fviernau
force-pushed
the
simplify-conandata-parsing
branch
from
078c153 to
172f8ac
Compare
Signed-off-by: Frank Viernau <[email protected]>
sschuberth
force-pushed
the
simplify-conandata-parsing
branch
from
172f8ac to
0fcab2d
Compare
sschuberth
approved these changes
Jul 18, 2024
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.