Conan improvements #8899
Merged
Conan improvements #8899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
In order to not loose information, merge relevant aspects of the functions KDoc. Signed-off-by: Frank Viernau <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8899 +/- ##
=========================================
Coverage 67.63% 67.63%
Complexity 1168 1168
=========================================
Files 244 244
Lines 7781 7781
Branches 867 867
=========================================
Hits 5263 5263
Misses 2161 2161
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
Jul 17, 2024
| @@ -180,7 +180,7 @@ class Conan( | |||
| dependencies = parseDependencyTree(pkgInfos, projectInfo.buildRequires, workingDir) | |||
| ) | |||
|
|
|||
| val projectPackage = parseProjectPackage(pkgInfos, definitionFile, workingDir) | |||
| val projectPackage = generateProjectPackage(projectInfo, definitionFile, workingDir) | |||
There was a problem hiding this comment.
Maybe also worth noting in the commit message: The caller's projectInfo equals the original function's projectPackage, so the inlining also avoids calculating the value again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparations for porting to KxS plus some code improvements.