feat(analyzer): Add option to skip setup.py analysis of PIP dependencies #8893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8893 +/- ##
============================================
- Coverage 67.54% 67.52% -0.03%
Complexity 1166 1166
============================================
Files 244 244
Lines 7775 7776 +1
Branches 865 866 +1
============================================
- Hits 5252 5251 -1
- Misses 2167 2169 +2
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
Jul 16, 2024
haikoschol
force-pushed
the
py-inspector-option
branch
from
fcf98cd to
e84525c
Compare
sschuberth
requested changes
Jul 17, 2024
Previously, the PIP package manager has always set the "--analyze-setup-py-insecurely" flag on invocations of python-inspector. This is a potential security risk, as python-inspector will execute setup.py files of resolved dependencies. It also causes analysis to fail if those setup.py files import packages that are not part of the Python standard library (such as numexpr in version 2.10.1). This change makes it configurable whether the flag is set or not. Signed-off-by: Haiko Schol <[email protected]>
haikoschol
force-pushed
the
py-inspector-option
branch
from
e84525c to
fd24c3c
Compare
sschuberth
approved these changes
Jul 17, 2024
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the PIP package manager has always set the
--analyze-setup-py-insecurelyflag on invocations ofpython-inspector. This is a potential security risk, aspython-inspectorwill executesetup.pyfiles of resolved dependencies.It also causes analysis to fail if those
setup.pyfiles import packages that are not part of the Python standard library (such asnumexprin version 2.10.1).This change makes it configurable whether the flag is set or not.