Cocoapods: Separate lockfile deserialization and its model #8890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the variable names more speaking and reduce the diff of an upcoming change. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
cocoapods-separate-deserialization-and-model
branch
from
3455d3f to
2c1624e
Compare
sschuberth
approved these changes
Jul 16, 2024
Signed-off-by: Frank Viernau <[email protected]>
Previously, parsing the lockfile and mapping it to ORT's model has all been done in the single function `parseLockfile(File)`. Define a model for the lockfile and a function for its parsing in a separate dedicated file in order to separate concerns. This makes the code easier to maintain and simplifies the upcoming porting to KxS. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
cocoapods-separate-deserialization-and-model
branch
from
2c1624e to
733b356
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8890 +/- ##
=========================================
Coverage 67.54% 67.54%
Complexity 1168 1168
=========================================
Files 244 244
Lines 7775 7775
Branches 865 865
=========================================
Hits 5252 5252
Misses 2167 2167
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the code to prepare for porting to KxS.
See individual commits.