fix(bazel): Always disable the wrapper script #8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nnobelis mind testing if this works? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fviernau
force-pushed
the
bazel-disable-wrapper
branch
2 times, most recently
from
3487171 to
254f05a
Compare
|
Yes it works, thanks. |
sschuberth
reviewed
Jul 3, 2024
Comment on lines
85
to
88
| environment = environment.toMutableMap().apply { | ||
| // Disable the optional wrapper script under `tools/bazel`, to ensure the --version option works. | ||
| put("BAZELISK_SKIP_WRAPPER", "true") | ||
| } |
There was a problem hiding this comment.
I propose to use the shorter environment + mapOf("BAZELISK_SKIP_WRAPPER" to "true") instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8835 +/- ##
=========================================
Coverage 67.79% 67.79%
Complexity 1164 1164
=========================================
Files 243 243
Lines 7711 7711
Branches 861 861
=========================================
Hits 5228 5228
Misses 2127 2127
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #8828. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
bazel-disable-wrapper
branch
from
254f05a to
310470d
Compare
sschuberth
approved these changes
Jul 3, 2024
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8828.