Add the DOS scanner wrapper #8792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
add-dos-scanner
branch
from
e25a6cd to
19831af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8792 +/- ##
=========================================
Coverage 67.79% 67.79%
Complexity 1164 1164
=========================================
Files 243 243
Lines 7711 7711
Branches 861 861
=========================================
Hits 5228 5228
Misses 2127 2127
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Etsija
reviewed
Jun 27, 2024
plugins/scanners/dos/README.md
Outdated
| ``` | ||
|
|
||
| where `DOS_SERVER_URL`, `DOS_FRONTEND_URL` and `DOS_SERVER_TOKEN` are environment variables that are set to the respective values. | ||
| The `DOS_FRONTEND_URL` is meant to points to the cleanrance UI which can be used to inspect scan results and to create license findings curations for use with the [DOS Package Configuration Provider]. |
There was a problem hiding this comment.
..."is meant to point to the Clearance UI"...
sschuberth
force-pushed
the
add-dos-scanner
branch
from
19831af to
d5a0942
Compare
mnonnenmacher
requested changes
Jun 27, 2024
This adds the ORT client side code for the scanner implemented as part of DOS [1]. [1]: https://github.com/doubleopen-project/dos Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
add-dos-scanner
branch
from
d5a0942 to
096459c
Compare
mnonnenmacher
approved these changes
Jun 27, 2024
|
The Docker Build failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.