Add the Double Open Server (DOS) client and package configuration provider #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8770 +/- ##
=========================================
Coverage 67.79% 67.79%
- Complexity 1164 1166 +2
=========================================
Files 243 243
Lines 7711 7711
Branches 861 861
=========================================
Hits 5228 5228
Misses 2127 2127
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
requested changes
Jun 19, 2024
sschuberth
force-pushed
the
add-dos-projects
branch
2 times, most recently
from
dbc4456 to
acd3a20
Compare
fviernau
requested changes
Jun 19, 2024
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Show resolved
Hide resolved
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Show resolved
Hide resolved
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
sschuberth
force-pushed
the
add-dos-projects
branch
from
acd3a20 to
0d0d7ab
Compare
fviernau
reviewed
Jun 20, 2024
plugins/package-configuration-providers/dos/src/main/kotlin/DosPackageConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
sschuberth
force-pushed
the
add-dos-projects
branch
from
0d0d7ab to
7e641ee
Compare
sschuberth
force-pushed
the
add-dos-projects
branch
2 times, most recently
from
a686d53 to
0d81279
Compare
This client library project provides the base for communicating with the DOS package configuration provider and DOS scanner wrapper. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
add-dos-projects
branch
from
0d81279 to
0a708d2
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
add-dos-projects
branch
from
0a708d2 to
82c72fa
Compare
fviernau
reviewed
Jun 24, 2024
| */ | ||
| suspend fun getUploadUrl(key: String): String? { | ||
| if (key.isEmpty()) { | ||
| logger.error { "Need the name of the zipped packet to upload" } |
There was a problem hiding this comment.
Is packet correct?
Missing trailing dot.
There was a problem hiding this comment.
I'll fix these in a follow-up, thanks.
| */ | ||
| suspend fun getScanJobState(id: String): JobStateResponseBody? { | ||
| if (id.isEmpty()) { | ||
| logger.error { "Need the job ID to check for job state" } |
fviernau
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DOS scanner wrapper will be contributed as a follow-up.