model: Eliminate the use of a SortedSet
#8694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
eliminate-dep-graph-sorted-set-part-1
branch
from
d3bd2bb
to
3e01ede
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8694 +/- ##
============================================
- Coverage 67.86% 67.85% -0.02%
Complexity 1165 1165
============================================
Files 244 244
Lines 7734 7736 +2
Branches 865 865
============================================
Hits 5249 5249
- Misses 2126 2128 +2
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Correct, but maps are also not collections 😅 But I cannot think of a better name either 😸 |
sschuberth
previously approved these changes
May 24, 2024
hehe, right. I missed that 😅 |
The file contains both, `SortedSet` and `SortedMap` converters. Signed-off-by: Frank Viernau <[email protected]>
Using a `SortedSet` is not required. Signed-off-by: Frank Viernau <[email protected]>
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
eliminate-dep-graph-sorted-set-part-1
branch
from
3e01ede
to
5012c79
Compare
sschuberth
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.
Part of #6235.