Subversion fixes #8572
Merged
Subversion fixes #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
svn-fixes
branch
2 times, most recently
from
c46831a to
33623c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8572 +/- ##
=========================================
Coverage 67.70% 67.70%
Complexity 1007 1007
=========================================
Files 246 246
Lines 7924 7924
Branches 883 883
=========================================
Hits 5365 5365
Misses 2176 2176
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously requested changes
Apr 26, 2024
| }.map { | ||
| revision | ||
| it.toString() |
There was a problem hiding this comment.
commit msg: Please provide a rationale.
Slightly improve logging in the caller to be able to remove similar logging in some implementations. Signed-off-by: Sebastian Schuberth <[email protected]>
This changes the state of the `updateClient` and only needs to be set once. Signed-off-by: Sebastian Schuberth <[email protected]>
One should not expect checking out the requested revision to always go well, but return the actual revision so the caller can double-check the requested against the actual revision. Signed-off-by: Sebastian Schuberth <[email protected]>
Simplify code to only do a single `svn switch`, and eventually an `svn update` if a path is specified. Signed-off-by: Sebastian Schuberth <[email protected]>
Ensure that always the first algorithm mentioned at [1] is applied. This avoids errors e.g. when updating to a resolved revision of a tag path. Fixes #6160. [1]: https://svnbook.red-bean.com/en/1.7/svn.advanced.pegrevs.html Signed-off-by: Sebastian Schuberth <[email protected]>
Recent changes made the test work. However, it may take up to 20 minutes to complete, so mark it as expensive. Signed-off-by: Sebastian Schuberth <[email protected]>
mnonnenmacher
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.