File walk alignments #8560
Merged
File walk alignments #8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Kotlin's `walk()`, in contrast to Java's `listFiles()`, also returns the directory to walk itself. So unless filtering for files is done anyway, special care needs to be taken to deal with the directory being walked. So change the code here a bit to explicitly deal with the walked directory as part of the filtering. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8560 +/- ##
=========================================
Coverage 67.68% 67.68%
Complexity 1006 1006
=========================================
Files 246 246
Lines 7924 7924
Branches 883 883
=========================================
Hits 5363 5363
Misses 2181 2181
Partials 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
file-walk-alignments
branch
from
ac0dc6f to
fcb4cea
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
`list(Files)` is a nullable Java platform call, so prefer the portable and more powerful Kotlin `walk`. Signed-off-by: Sebastian Schuberth <[email protected]>
Make this more similar to the code used in other tests in the same file. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
file-walk-alignments
branch
from
fcb4cea to
7da0deb
Compare
fviernau
requested changes
Apr 25, 2024
fviernau
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.