Address a possible Gradle progress listener bug #8425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not always registering a `ProgressListener` that, depening on the log level, eventually does not nothing is good practice anyway, and it helps to circumvent a bug with Gradle 8.5 [1] when analyzing such projects. [1]: gradle/gradle#28464 Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
gradle-progress-listener-bug
branch
2 times, most recently
from
b22fb29 to
62bee82
Compare
Signed-off-by: Sebastian Schuberth <[email protected]>
Align with the code from the "legacy" Gradle package manager implementation. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
gradle-progress-listener-bug
branch
from
62bee82 to
8322615
Compare
|
@sschuberth Thanks for the fast response! Can confirm the fix resolved the issue with a repo that failed previously due to the bug. |
fviernau
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
Big thanks to @brigaccess for findings and filing gradle/gradle#28464!