Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify storage readers #8422

Merged
merged 10 commits into from
Mar 18, 2024

refactor(scanner)!: Rename the package based storages

293a806
Select commit
Loading
Failed to load commit list.
Merged

Simplify storage readers #8422

refactor(scanner)!: Rename the package based storages
293a806
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 18, 2024 in 0s

67.67% (+0.02%) compared to 6c6ddbf

View this Pull Request on Codecov

67.67% (+0.02%) compared to 6c6ddbf

Details

Codecov Report

Attention: Patch coverage is 71.42857% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 67.67%. Comparing base (6c6ddbf) to head (293a806).
Report is 3 commits behind head on main.

Files Patch % Lines
...kotlin/storages/AbstractPackageBasedScanStorage.kt 70.37% 8 Missing ⚠️
...rc/main/kotlin/storages/PackageBasedFileStorage.kt 42.85% 1 Missing and 3 partials ⚠️
...ain/kotlin/storages/PackageBasedPostgresStorage.kt 81.25% 0 Missing and 3 partials ⚠️
...c/main/kotlin/commands/ImportScanResultsCommand.kt 0.00% 1 Missing ⚠️
...ain/kotlin/commands/packageconfig/CreateCommand.kt 0.00% 1 Missing ⚠️
scanner/src/main/kotlin/storages/Sw360Storage.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #8422      +/-   ##
============================================
+ Coverage     67.65%   67.67%   +0.02%     
- Complexity      987      999      +12     
============================================
  Files           246      247       +1     
  Lines          7914     7907       -7     
  Branches        871      875       +4     
============================================
- Hits           5354     5351       -3     
+ Misses         2179     2175       -4     
  Partials        381      381

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov