Small refactor docker build to solve race condition with functional tests #8396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funTest-docker job has an indirect race condition when in the same CI job a new docker image is scheduled to build. If any new tooling version depends of update test dataset, the tests will run against docker snapshot version that is not the expected image the new code should test. To prevent this race conditions, funTest-docker will run only if the docker image is scheduled to be build, handling the tests no this case to the ort-docker workflow. Signed-off-by: Helio Chissini de Castro <[email protected]>
heliocastro
force-pushed
the
heliocastro/funtest_docker
branch
6 times, most recently
from
b787c85 to
63eef92
Compare
heliocastro
force-pushed
the
heliocastro/funtest_docker
branch
from
63eef92 to
bfb4f7d
Compare
|
Different pull_request will be issued soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.