fix(SpdxDocumentFile): Support nested DEPENDS_ON relations
#8376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
plugins/package-managers/spdx/src/funTest/kotlin/SpdxDocumentFileFunTest.kt
Fixed
Show fixed
Hide fixed
Thanks a lot for the contribution, @JSurf! I believe we should explain the above in more detail in the commit message. I propose to add: The last line will cause the issue to get auto-closed upon merge of the PR. |
sschuberth
requested changes
Mar 5, 2024
plugins/package-managers/spdx/src/funTest/kotlin/SpdxDocumentFileFunTest.kt
Outdated
Show resolved
Hide resolved
...-managers/spdx/src/funTest/assets/projects/synthetic/dependson-packages/project-xyz.spdx.yml
Outdated
Show resolved
Hide resolved
JSurf
force-pushed
the
fix-depends-on
branch
2 times, most recently
from
43ff749 to
91083a9
Compare
While the `getDependencies()` function overload that takes the `dependencyOfRelation` argument is generic with respect to the relationship, whenever `DEPENDENCY_OF` is passed, also `dependsOnCase` should be passed to handle dependency relationships bidirectionally. This is exactly what the `getDependencies()` convenience function that only takes three arguments is there for, so make use of that. Also add a new test case to cover the `DEPENDS_ON` case. Fixes oss-review-toolkit#8359. Signed-off-by: Jens Viebig <[email protected]>
|
@sschuberth Made requested changes, please review again |
sschuberth
approved these changes
Mar 6, 2024
sschuberth
changed the title
DEPENDS_ON relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes nested DEPENDS_ON relations as discussed in:
#8359
The main issue was that the dependsOnCase function is not always correctly defined.
There might be a better way to restructure the code and also support other nested relationships (if this is wanted) but my kotlin skills are very limited to do further improvements