refactor(scanner)!: Align provenance storages on write instead of put
#8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put` Say `write` instead of `put` to match `read` functions and to align with the `ScanStorage` interfaces. Signed-off-by: Sebastian Schuberth <[email protected]>
|
As discussed, @mnonnenmacher. |
fviernau
reviewed
Feb 21, 2024
| * Put the resolution [result] for the [root] provenance into the storage. If the storage already contains an entry | ||
| * for [root] it is overwritten. | ||
| * Write the resolution [result] for the [root] provenance into the storage. If the storage already contains an | ||
| * entry for [root] it is overwritten. |
There was a problem hiding this comment.
out of scope: I've recently mentioned (slack) the constraint violations in the logs which occur when the entry already exists. Without looking into it, I guess that it's actually not overwritten but ignored in the Postgres based implementation.
There was a problem hiding this comment.
@fviernau I'm only aware of possible constraint violations related to storing scan results, but not for provenance resolution results.
mnonnenmacher
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say
writeinstead ofputto matchreadfunctions and to align with theScanStorageinterfaces.