Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Base64-encoding #8317

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Kotlin Base64-encoding #8317

merged 3 commits into from
Feb 20, 2024

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

This avoids the need for `KotlinCompile` task configuration here.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth requested a review from a team as a code owner February 20, 2024 15:04
@sschuberth sschuberth force-pushed the kotlin-base64-encoding branch from 16b4660 to 7a3ad8d Compare February 20, 2024 15:13
@sschuberth sschuberth marked this pull request as draft February 20, 2024 15:38
fviernau
fviernau previously approved these changes Feb 20, 2024
@sschuberth sschuberth force-pushed the kotlin-base64-encoding branch from 7a3ad8d to 76a2057 Compare February 20, 2024 15:51
@sschuberth sschuberth marked this pull request as ready for review February 20, 2024 15:52
@sschuberth sschuberth requested review from fviernau and a team February 20, 2024 15:52
…nApi`

This reduces code duplication and bundles `-opt-in` arguments. Note that
the manual task configuration needs to stay for projects that do not
use the plugin, but whose tests use experimental serialization API
directly, like `ScanOssResultParserTest`.

Signed-off-by: Sebastian Schuberth <[email protected]>
Use Kotlin's built-in functionality as much as possible for portability.

Signed-off-by: Sebastian Schuberth <[email protected]>
@sschuberth sschuberth force-pushed the kotlin-base64-encoding branch from 76a2057 to cef9531 Compare February 20, 2024 15:54
@sschuberth sschuberth merged commit 0374af1 into main Feb 20, 2024
19 of 21 checks passed
@sschuberth sschuberth deleted the kotlin-base64-encoding branch February 20, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants