Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify storage code #8312

Merged
merged 2 commits into from
Feb 20, 2024

refactor(ort-utils): Remove some superfluous `apply` statements

a8e0203
Select commit
Loading
Failed to load commit list.
Merged

Simplify storage code #8312

refactor(ort-utils): Remove some superfluous `apply` statements
a8e0203
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 20, 2024 in 0s

67.44% (-0.26%) compared to b4675eb

View this Pull Request on Codecov

67.44% (-0.26%) compared to b4675eb

Details

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (b4675eb) 67.69% compared to head (a8e0203) 67.44%.

Files Patch % Lines
utils/ort/src/main/kotlin/storage/S3FileStorage.kt 0.00% 17 Missing ⚠️
...ils/ort/src/main/kotlin/storage/HttpFileStorage.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8312      +/-   ##
============================================
- Coverage     67.69%   67.44%   -0.26%     
+ Complexity      973      967       -6     
============================================
  Files           240      240              
  Lines          7835     7833       -2     
  Branches        865      865              
============================================
- Hits           5304     5283      -21     
- Misses         2148     2168      +20     
+ Partials        383      382       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.