fix(scanner): Catch a DownloadException instead of IOException
#8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `downloadRecursively()` function rethrows `IOException` as `DownloadException`, so the latter needs to be catched here. Signed-off-by: Sebastian Schuberth <[email protected]>
…tion Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
fix-dl-exception
branch
from
08e9c42 to
81e1cad
Compare
fviernau
approved these changes
Feb 19, 2024
fviernau
previously requested changes
Feb 19, 2024
I'm not sure whether this is the only cause, so I left it open for now for the OP to confirm the bug to be resolved, and close manually. |
fviernau
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
downloadRecursively()function rethrowsIOExceptionasDownloadException, so the latter needs to be catched here.