Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): Check if owner is an organization or user #8300

Closed
wants to merge 1 commit into from

Conversation

heliocastro
Copy link
Contributor

GitHub API endpoints differ for organisations and users, and before check_image script assuming organisations only. The side effect is individual users using Ort Docker workflow having all layers rebuilt on every commit that triggers Docker builds.

@heliocastro heliocastro self-assigned this Feb 18, 2024
@heliocastro heliocastro requested a review from a team as a code owner February 18, 2024 10:56
@heliocastro heliocastro force-pushed the heliocastro/image_check branch from a971fe8 to 05d01f2 Compare February 19, 2024 19:58
@tsteenbe tsteenbe force-pushed the heliocastro/image_check branch from 83e6f2d to 7345bde Compare February 22, 2024 08:10
GitHub API endpoints differ for organisations and users, and before
check_image script assuming organisations only.
The side effect is individual users using Ort Docker workflow having
all layers rebuilt on every commit that triggers Docker builds.

Signed-off-by: Helio Chissini de Castro <[email protected]>
@heliocastro heliocastro force-pushed the heliocastro/image_check branch from 7345bde to 7b04ce3 Compare February 22, 2024 13:36
@heliocastro heliocastro enabled auto-merge (rebase) February 22, 2024 13:37
@heliocastro
Copy link
Contributor Author

Superseded by #8458

auto-merge was automatically disabled March 25, 2024 08:42

Pull request was closed

@sschuberth sschuberth deleted the heliocastro/image_check branch March 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant