Fix some SPDX license processing issues #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with the naming of similar blocks. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
This keeps test blocks named after functions grouped at the bottom. Signed-off-by: Sebastian Schuberth <[email protected]>
Show that for compound expressions the expression is a sub-expression of itself. Signed-off-by: Sebastian Schuberth <[email protected]>
Align with the semantics for compound expressions. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
spdx-issues
branch
from
0117862 to
a1cb37e
Compare
mnonnenmacher
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Commit message: "any anyway", "is be too strict"
The string-approach fails for compound expressions whose second operand ends with an exception (the `WITH` operator binds stronger than `AND` / `OR`). As the string comparison was meant as a performance optimization anyway, just remove it. In exchange, a special case for the `AND` operator is required, for which the `containsAll()` check with valid choices is too strict: All valid choices for an `AND` expression would contain the `AND` itself. However, sub-expressions should be allowed to also match only either side of the `AND`. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
spdx-issues
branch
from
a1cb37e to
7a646a1
Compare
mnonnenmacher
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.