fix(vulnerable-code): Correct an URL escape fixup case #8224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
vc-escape-fixup-fixup
branch
2 times, most recently
from
bd8679e to
45a34f3
Compare
mnonnenmacher
requested changes
Feb 6, 2024
This is a fixup for 6ec2a31. As this actually fixes the case that was used as an invalid URL in a test, simply remove that test, as the goal is to not have invalid URLs by fixing them up anyway. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
vc-escape-fixup-fixup
branch
from
45a34f3 to
8993516
Compare
mnonnenmacher
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for 6ec2a31.